crypto: chtls - remove redundant null pointer check before kfree_skb
authorzhong jiang <zhongjiang@huawei.com>
Thu, 20 Sep 2018 09:57:16 +0000 (17:57 +0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 28 Sep 2018 04:46:26 +0000 (12:46 +0800)
kfree_skb has taken the null pointer into account. hence it is safe
to remove the redundant null pointer check before kfree_skb.

Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/chelsio/chtls/chtls_cm.c
drivers/crypto/chelsio/chtls/chtls_main.c

index 0997e16..fd2ae1e 100644 (file)
@@ -234,8 +234,7 @@ static void chtls_send_reset(struct sock *sk, int mode, struct sk_buff *skb)
 
        return;
 out:
-       if (skb)
-               kfree_skb(skb);
+       kfree_skb(skb);
 }
 
 static void release_tcp_port(struct sock *sk)
index f59b044..f472c51 100644 (file)
@@ -272,8 +272,7 @@ static void chtls_free_uld(struct chtls_dev *cdev)
        for (i = 0; i < (1 << RSPQ_HASH_BITS); i++)
                kfree_skb(cdev->rspq_skb_cache[i]);
        kfree(cdev->lldi);
-       if (cdev->askb)
-               kfree_skb(cdev->askb);
+       kfree_skb(cdev->askb);
        kfree(cdev);
 }