drm/amdgpu/jpeg: remove redundant check when it returns
authorLeo Liu <leo.liu@amd.com>
Fri, 14 Aug 2020 15:08:59 +0000 (11:08 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 18 Aug 2020 22:22:16 +0000 (18:22 -0400)
Fix warning from kernel test robot
v2: remove the local variable as well

Signed-off-by: Leo Liu <leo.liu@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Acked-by: Nirmoy Das <nirmoy.das@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/jpeg_v3_0.c

index c41e559..3a0dff5 100644 (file)
@@ -460,15 +460,10 @@ static bool jpeg_v3_0_is_idle(void *handle)
 static int jpeg_v3_0_wait_for_idle(void *handle)
 {
        struct amdgpu_device *adev = (struct amdgpu_device *)handle;
-       int ret;
 
-       ret = SOC15_WAIT_ON_RREG(JPEG, 0, mmUVD_JRBC_STATUS,
+       return SOC15_WAIT_ON_RREG(JPEG, 0, mmUVD_JRBC_STATUS,
                UVD_JRBC_STATUS__RB_JOB_DONE_MASK,
                UVD_JRBC_STATUS__RB_JOB_DONE_MASK);
-       if (ret)
-               return ret;
-
-       return ret;
 }
 
 static int jpeg_v3_0_set_clockgating_state(void *handle,