wifi: rtlwifi: rtl8821ae: phy: remove some useless code
authorSu Hui <suhui@nfschina.com>
Mon, 27 Nov 2023 01:35:11 +0000 (09:35 +0800)
committerKalle Valo <kvalo@kernel.org>
Thu, 30 Nov 2023 19:22:06 +0000 (21:22 +0200)
Clang static checker warns:

Value stored to 'v1' is never read [deadcode.DeadStores]
Value stored to 'channel' is never read [deadcode.DeadStores]

Remove them to save some place.

Signed-off-by: Su Hui <suhui@nfschina.com>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20231127013511.26694-1-suhui@nfschina.com
drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c

index 5323ead..6df270e 100644 (file)
@@ -2038,15 +2038,9 @@ static bool _rtl8821ae_phy_config_bb_with_pgheaderfile(struct ieee80211_hw *hw,
                         /*don't need the hw_body*/
                        if (!_rtl8821ae_check_condition(hw, v1)) {
                                i += 2; /* skip the pair of expression*/
-                               v1 = array[i];
                                v2 = array[i+1];
-                               v3 = array[i+2];
-                               while (v2 != 0xDEAD) {
+                               while (v2 != 0xDEAD)
                                        i += 3;
-                                       v1 = array[i];
-                                       v2 = array[i+1];
-                                       v3 = array[i+2];
-                               }
                        }
                }
        }
@@ -3543,7 +3537,6 @@ u8 rtl8821ae_phy_sw_chnl(struct ieee80211_hw *hw)
        struct rtl_phy *rtlphy = &rtlpriv->phy;
        struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
        u32 timeout = 1000, timecount = 0;
-       u8 channel = rtlphy->current_channel;
 
        if (rtlphy->sw_chnl_inprogress)
                return 0;
@@ -3566,8 +3559,6 @@ u8 rtl8821ae_phy_sw_chnl(struct ieee80211_hw *hw)
                rtl8821ae_phy_switch_wirelessband(hw, BAND_ON_2_4G);
 
        rtlphy->sw_chnl_inprogress = true;
-       if (channel == 0)
-               channel = 1;
 
        rtl_dbg(rtlpriv, COMP_SCAN, DBG_TRACE,
                "switch to channel%d, band type is %d\n",