drm/amdgpu/firmware: move debugfs init into core amdgpu debugfs
authorAlex Deucher <alexander.deucher@amd.com>
Tue, 4 Feb 2020 18:11:50 +0000 (13:11 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 26 Feb 2020 19:21:12 +0000 (14:21 -0500)
In order to remove the load and unload drm callbacks,
we need to reorder the init sequence to move all the drm
debugfs file handling.  Do this for firmware.

Tested-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c

index 444a072..6dbc312 100644 (file)
@@ -1312,6 +1312,10 @@ int amdgpu_debugfs_init(struct amdgpu_device *adev)
        if (r)
                DRM_ERROR("registering register debugfs failed (%d).\n", r);
 
+       r = amdgpu_debugfs_firmware_init(adev);
+       if (r)
+               DRM_ERROR("registering firmware debugfs failed (%d).\n", r);
+
        return amdgpu_debugfs_add_files(adev, amdgpu_debugfs_list,
                                        ARRAY_SIZE(amdgpu_debugfs_list));
 }
index d74ad2a..008797c 100644 (file)
@@ -3120,10 +3120,6 @@ fence_driver_init:
        } else
                adev->ucode_sysfs_en = true;
 
-       r = amdgpu_debugfs_firmware_init(adev);
-       if (r)
-               DRM_ERROR("registering firmware debugfs failed (%d).\n", r);
-
        r = amdgpu_debugfs_init(adev);
        if (r)
                DRM_ERROR("Creating debugfs files failed (%d).\n", r);