mlxsw: remove I2C_CLASS_HWMON from drivers w/o detect and address_list
authorHeiner Kallweit <hkallweit1@gmail.com>
Sat, 27 Jan 2024 15:08:18 +0000 (16:08 +0100)
committerJakub Kicinski <kuba@kernel.org>
Wed, 31 Jan 2024 01:51:45 +0000 (17:51 -0800)
Class-based I2C probing requires detect() and address_list to be
set in the I2C client driver, see checks in i2c_detect().
It's misleading to declare I2C_CLASS_HWMON support if this
precondition isn't met.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Link: https://lore.kernel.org/r/77b5ab8e-20f2-4310-bd89-57db99e2f53b@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mellanox/mlxsw/minimal.c

index 6b98c32..f0ceb19 100644 (file)
@@ -708,7 +708,6 @@ static const struct i2c_device_id mlxsw_m_i2c_id[] = {
 
 static struct i2c_driver mlxsw_m_i2c_driver = {
        .driver.name = "mlxsw_minimal",
-       .class = I2C_CLASS_HWMON,
        .id_table = mlxsw_m_i2c_id,
 };