misc: vexpress/syscfg: Use devm_ioremap_resource() to map memory
authorSudeep Holla <sudeep.holla@arm.com>
Wed, 11 Jul 2018 15:17:39 +0000 (16:17 +0100)
committerSudeep Holla <sudeep.holla@arm.com>
Thu, 12 Jul 2018 17:06:01 +0000 (18:06 +0100)
Instead of checking the return value of platform_get_resource(), we can
use devm_ioremap_resource() which has the NULL pointer check and the
memory region requesting. devm_ioremap_resource is designed to replace
calls to devm_request_mem_region followed by devm_ioremap, so let's use
the same.

Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Acked-by: Liviu Dudau <liviu.dudau@arm.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
drivers/misc/vexpress-syscfg.c

index 80a6f19..6c3591c 100644 (file)
@@ -258,13 +258,9 @@ static int vexpress_syscfg_probe(struct platform_device *pdev)
        INIT_LIST_HEAD(&syscfg->funcs);
 
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       if (!devm_request_mem_region(&pdev->dev, res->start,
-                       resource_size(res), pdev->name))
-               return -EBUSY;
-
-       syscfg->base = devm_ioremap(&pdev->dev, res->start, resource_size(res));
-       if (!syscfg->base)
-               return -EFAULT;
+       syscfg->base = devm_ioremap_resource(&pdev->dev, res);
+       if (IS_ERR(syscfg->base))
+               return PTR_ERR(syscfg->base);
 
        /* Must use dev.parent (MFD), as that's where DT phandle points at... */
        bridge = vexpress_config_bridge_register(pdev->dev.parent,