accel/ivpu/37xx: Print warning when VPUIP is not idle during power down
authorStanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
Sat, 28 Oct 2023 13:34:14 +0000 (15:34 +0200)
committerStanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
Mon, 30 Oct 2023 10:06:13 +0000 (11:06 +0100)
Print warning if VPUIP is not idle during power down.

Use warn log level also when we fail to enter reset state
as this is not really an error but unexpected behavior.

Reviewed-by: Krystian Pradzynski <krystian.pradzynski@linux.intel.com>
Signed-off-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231028133415.1169975-11-stanislaw.gruszka@linux.intel.com
drivers/accel/ivpu/ivpu_hw_37xx.c

index 451c977..1b47d77 100644 (file)
@@ -726,8 +726,11 @@ static int ivpu_hw_37xx_power_down(struct ivpu_device *vdev)
 
        ivpu_hw_37xx_save_d0i3_entry_timestamp(vdev);
 
-       if (!ivpu_hw_37xx_is_idle(vdev) && ivpu_hw_37xx_reset(vdev))
-               ivpu_err(vdev, "Failed to reset the VPU\n");
+       if (!ivpu_hw_37xx_is_idle(vdev)) {
+               ivpu_warn(vdev, "VPU not idle during power down\n");
+               if (ivpu_hw_37xx_reset(vdev))
+                       ivpu_warn(vdev, "Failed to reset the VPU\n");
+       }
 
        if (ivpu_pll_disable(vdev)) {
                ivpu_err(vdev, "Failed to disable PLL\n");