ext4: Reduce ext4 timestamp warnings
authorDeepa Dinamani <deepa.kernel@gmail.com>
Wed, 4 Sep 2019 15:02:51 +0000 (08:02 -0700)
committerArnd Bergmann <arnd@arndb.de>
Wed, 4 Sep 2019 20:54:53 +0000 (22:54 +0200)
When ext4 file systems were created intentionally with 128 byte inodes,
the rate-limited warning of eventual possible timestamp overflow are
still emitted rather frequently.  Remove the warning for now.

Discussion for whether any warning is needed,
and where it should be emitted, can be found at
https://lore.kernel.org/lkml/1567523922.5576.57.camel@lca.pw/.
I can post a separate follow-up patch after the conclusion.

Reported-by: Qian Cai <cai@lca.pw>
Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
fs/ext4/ext4.h

index 9e3ae3b..24b14bd 100644 (file)
@@ -833,10 +833,8 @@ do {                                                                               \
                (raw_inode)->xtime ## _extra =                                  \
                                ext4_encode_extra_time(&(inode)->xtime);        \
                }                                                               \
-       else    {\
+       else    \
                (raw_inode)->xtime = cpu_to_le32(clamp_t(int32_t, (inode)->xtime.tv_sec, S32_MIN, S32_MAX));    \
-               ext4_warning_inode(inode, "inode does not support timestamps beyond 2038"); \
-       } \
 } while (0)
 
 #define EXT4_EINODE_SET_XTIME(xtime, einode, raw_inode)                               \