acpi-cpufreq: Fix nominal_freq units to KHz in get_max_boost_ratio()
authorGautham R. Shenoy <gautham.shenoy@amd.com>
Thu, 29 May 2025 08:51:43 +0000 (14:21 +0530)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 29 May 2025 13:20:45 +0000 (15:20 +0200)
commit 083466754596 ("cpufreq: ACPI: Fix max-frequency computation")
modified get_max_boost_ratio() to return the nominal_freq advertised
in the _CPC object. This was for the purposes of computing the maximum
frequency. The frequencies advertised in _CPC objects are in
MHz. However, cpufreq expects the frequency to be in KHz. Since the
nominal_freq returned by get_max_boost_ratio() was not in KHz but
instead in MHz,the cpuinfo_max_frequency that was computed using this
nominal_freq was incorrect and an invalid value which resulted in
cpufreq reporting the P0 frequency as the cpuinfo_max_freq.

Fix this by converting the nominal_freq to KHz before returning the
same from get_max_boost_ratio().

Reported-by: Manu Bretelle <chantr4@gmail.com>
Closes: https://lore.kernel.org/lkml/aDaB63tDvbdcV0cg@HQ-GR2X1W2P57/
Fixes: 083466754596 ("cpufreq: ACPI: Fix max-frequency computation")
Signed-off-by: Gautham R. Shenoy <gautham.shenoy@amd.com>
Cc: 6.14+ <stable@vger.kernel.org> # 6.14+
Link: https://patch.msgid.link/20250529085143.709-1-gautham.shenoy@amd.com
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/cpufreq/acpi-cpufreq.c

index d26b610..76768fe 100644 (file)
@@ -660,7 +660,7 @@ static u64 get_max_boost_ratio(unsigned int cpu, u64 *nominal_freq)
        nominal_perf = perf_caps.nominal_perf;
 
        if (nominal_freq)
-               *nominal_freq = perf_caps.nominal_freq;
+               *nominal_freq = perf_caps.nominal_freq * 1000;
 
        if (!highest_perf || !nominal_perf) {
                pr_debug("CPU%d: highest or nominal performance missing\n", cpu);