hwmon: (ltc2947) Switch to EXPORT_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr()
authorJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 25 Sep 2022 17:27:49 +0000 (18:27 +0100)
committerGuenter Roeck <linux@roeck-us.net>
Sun, 25 Sep 2022 21:22:12 +0000 (14:22 -0700)
These newer PM macros allow the compiler to see what code it can remove
if !CONFIG_PM_SLEEP. This allows the removal of __maybe_unused markings
whilst achieving the same result. In this case it also lets the
structure itself be removed.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Nuno Sá <nuno.sa@analog.com>
Link: https://lore.kernel.org/r/20220925172759.3573439-9-jic23@kernel.org
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/ltc2947-core.c
drivers/hwmon/ltc2947-i2c.c
drivers/hwmon/ltc2947-spi.c

index 626f5bf..7404e97 100644 (file)
@@ -1120,7 +1120,7 @@ int ltc2947_core_probe(struct regmap *map, const char *name)
 }
 EXPORT_SYMBOL_GPL(ltc2947_core_probe);
 
-static int __maybe_unused ltc2947_resume(struct device *dev)
+static int ltc2947_resume(struct device *dev)
 {
        struct ltc2947_data *st = dev_get_drvdata(dev);
        u32 ctrl = 0;
@@ -1149,7 +1149,7 @@ static int __maybe_unused ltc2947_resume(struct device *dev)
                                  LTC2947_CONT_MODE_MASK, LTC2947_CONT_MODE(1));
 }
 
-static int __maybe_unused ltc2947_suspend(struct device *dev)
+static int ltc2947_suspend(struct device *dev)
 {
        struct ltc2947_data *st = dev_get_drvdata(dev);
 
@@ -1157,8 +1157,7 @@ static int __maybe_unused ltc2947_suspend(struct device *dev)
                                  LTC2947_SHUTDOWN_MASK, 1);
 }
 
-SIMPLE_DEV_PM_OPS(ltc2947_pm_ops, ltc2947_suspend, ltc2947_resume);
-EXPORT_SYMBOL_GPL(ltc2947_pm_ops);
+EXPORT_SIMPLE_DEV_PM_OPS(ltc2947_pm_ops, ltc2947_suspend, ltc2947_resume);
 
 const struct of_device_id ltc2947_of_match[] = {
        { .compatible = "adi,ltc2947" },
index ad0dfd3..96852bc 100644 (file)
@@ -36,7 +36,7 @@ static struct i2c_driver ltc2947_driver = {
        .driver = {
                .name = "ltc2947",
                .of_match_table = ltc2947_of_match,
-               .pm = &ltc2947_pm_ops,
+               .pm = pm_sleep_ptr(&ltc2947_pm_ops),
        },
        .probe_new = ltc2947_probe,
        .id_table = ltc2947_id,
index c24ca56..a33be11 100644 (file)
@@ -38,7 +38,7 @@ static struct spi_driver ltc2947_driver = {
        .driver = {
                .name = "ltc2947",
                .of_match_table = ltc2947_of_match,
-               .pm = &ltc2947_pm_ops,
+               .pm = pm_sleep_ptr(&ltc2947_pm_ops),
        },
        .probe = ltc2947_probe,
        .id_table = ltc2947_id,