qtnfmac: Simplify code in _attach functions
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Tue, 7 Apr 2020 19:32:33 +0000 (21:32 +0200)
committerKalle Valo <kvalo@codeaurora.org>
Tue, 14 Apr 2020 15:08:45 +0000 (18:08 +0300)
There is no need to re-implement 'netdev_alloc_skb_ip_align()' here.
Keep the code simple.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200407193233.9439-1-christophe.jaillet@wanadoo.fr
drivers/net/wireless/quantenna/qtnfmac/pcie/pearl_pcie.c
drivers/net/wireless/quantenna/qtnfmac/pcie/topaz_pcie.c

index dbb2411..eb67b66 100644 (file)
@@ -286,7 +286,7 @@ static int pearl_skb2rbd_attach(struct qtnf_pcie_pearl_state *ps, u16 index)
        struct sk_buff *skb;
        dma_addr_t paddr;
 
-       skb = __netdev_alloc_skb_ip_align(NULL, SKB_BUF_SIZE, GFP_ATOMIC);
+       skb = netdev_alloc_skb_ip_align(NULL, SKB_BUF_SIZE);
        if (!skb) {
                priv->rx_skb[index] = NULL;
                return -ENOMEM;
index dbf3c5f..d1b850a 100644 (file)
@@ -247,7 +247,7 @@ topaz_skb2rbd_attach(struct qtnf_pcie_topaz_state *ts, u16 index, u32 wrap)
        struct sk_buff *skb;
        dma_addr_t paddr;
 
-       skb = __netdev_alloc_skb_ip_align(NULL, SKB_BUF_SIZE, GFP_ATOMIC);
+       skb = netdev_alloc_skb_ip_align(NULL, SKB_BUF_SIZE);
        if (!skb) {
                ts->base.rx_skb[index] = NULL;
                return -ENOMEM;