Input: aiptek - remove redundant assignment to variable ret
authorColin Ian King <colin.i.king@gmail.com>
Mon, 18 Apr 2022 18:46:32 +0000 (11:46 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Wed, 20 Apr 2022 20:41:17 +0000 (13:41 -0700)
Variable ret is being assigned a value that is never read, it is
being re-assigned again in either path of the if statement. The
assignment is redundant and can be removed.

Cleans up clang scan build warning:
Although the value stored to 'ret' is used in the enclosing expression,
the value is never actually read from 'ret' [deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Link: https://lore.kernel.org/r/20220418142457.84708-1-colin.i.king@gmail.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/tablet/aiptek.c

index fcb1b64..3cd8ba7 100644 (file)
@@ -931,8 +931,7 @@ aiptek_query(struct aiptek *aiptek, unsigned char command, unsigned char data)
        }
        msleep(aiptek->curSetting.programmableDelay);
 
-       if ((ret =
-            aiptek_get_report(aiptek, 3, 2, buf, sizeof_buf)) != sizeof_buf) {
+       if (aiptek_get_report(aiptek, 3, 2, buf, sizeof_buf) != sizeof_buf) {
                dev_dbg(&aiptek->intf->dev,
                        "aiptek_query failed: returned 0x%02x 0x%02x 0x%02x\n",
                        buf[0], buf[1], buf[2]);