mfd: qcom-pm8008: Remove workaround for a regmap-irq quirk

Remove pm8008_init(), which according to the comments exists only
as a workaround for regmap-irq's odd treatment of type registers.
This workaround shouldn't be needed anymore because this driver
uses config registers, which are always programmed by regmap-irq
no matter what the initial register state is.

Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
Signed-off-by: Lee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20230216222214.138671-5-aidanmacdonald.0x0@gmail.com

diff --git a/drivers/mfd/qcom-pm8008.c b/drivers/mfd/qcom-pm8008.c
index 54fc9c2..837246a 100644 (file)
--- a/drivers/mfd/qcom-pm8008.c
+++ b/drivers/mfd/qcom-pm8008.c
@@ -143,30 +143,6 @@ static struct regmap_config qcom_mfd_regmap_cfg = {
        .max_register   = 0xFFFF,
 };
 
-static int pm8008_init(struct regmap *regmap)
-{
-       int rc;
-
-       /*
-        * Set TEMP_ALARM peripheral's TYPE so that the regmap-irq framework
-        * reads this as the default value instead of zero, the HW default.
-        * This is required to enable the writing of TYPE registers in
-        * regmap_irq_sync_unlock().
-        */
-       rc = regmap_write(regmap, (PM8008_TEMP_ALARM_ADDR | INT_SET_TYPE_OFFSET), BIT(0));
-       if (rc)
-               return rc;
-
-       /* Do the same for GPIO1 and GPIO2 peripherals */
-       rc = regmap_write(regmap, (PM8008_GPIO1_ADDR | INT_SET_TYPE_OFFSET), BIT(0));
-       if (rc)
-               return rc;
-
-       rc = regmap_write(regmap, (PM8008_GPIO2_ADDR | INT_SET_TYPE_OFFSET), BIT(0));
-
-       return rc;
-}
-
 static int pm8008_probe_irq_peripherals(struct device *dev,
                                        struct regmap *regmap,
                                        int client_irq)
@@ -175,12 +151,6 @@ static int pm8008_probe_irq_peripherals(struct device *dev,
        struct regmap_irq_type *type;
        struct regmap_irq_chip_data *irq_data;
 
-       rc = pm8008_init(regmap);
-       if (rc) {
-               dev_err(dev, "Init failed: %d\n", rc);
-               return rc;
-       }
-
        for (i = 0; i < ARRAY_SIZE(pm8008_irqs); i++) {
                type = &pm8008_irqs[i].type;