coresight: tpda: fix return value check in tpda_probe()
authorYang Yingliang <yangyingliang@huawei.com>
Sun, 29 Jan 2023 08:42:46 +0000 (16:42 +0800)
committerSuzuki K Poulose <suzuki.poulose@arm.com>
Mon, 30 Jan 2023 09:42:35 +0000 (09:42 +0000)
devm_ioremap_resource() never returns NULL pointer, it
will return ERR_PTR() when it fails, so replace the check
with IS_ERR().

Fixes: 5b7916625c01 ("Coresight: Add TPDA link driver")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
[ Fix return value to the PTR_ERR(base) ]
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Link: https://lore.kernel.org/r/20230129084246.537694-1-yangyingliang@huawei.com
drivers/hwtracing/coresight/coresight-tpda.c

index 382d648..f712e11 100644 (file)
@@ -145,8 +145,8 @@ static int tpda_probe(struct amba_device *adev, const struct amba_id *id)
        dev_set_drvdata(dev, drvdata);
 
        base = devm_ioremap_resource(dev, &adev->res);
-       if (!base)
-               return -ENOMEM;
+       if (IS_ERR(base))
+               return PTR_ERR(base);
        drvdata->base = base;
 
        spin_lock_init(&drvdata->spinlock);