net: vertexcom: mse102x: Use DEFINE_SIMPLE_DEV_PM_OPS
authorStefan Wahren <wahrenst@gmx.net>
Tue, 27 Aug 2024 19:09:56 +0000 (21:09 +0200)
committerJakub Kicinski <kuba@kernel.org>
Thu, 29 Aug 2024 18:39:35 +0000 (11:39 -0700)
This macro has the advantage over SET_SYSTEM_SLEEP_PM_OPS that we don't
have to care about when the functions are actually used.

Also make use of pm_sleep_ptr() to discard all PM_SLEEP related
stuff if CONFIG_PM_SLEEP isn't enabled.

Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20240827191000.3244-2-wahrenst@gmx.net
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/vertexcom/mse102x.c

index edd8b59..0711641 100644 (file)
@@ -622,8 +622,6 @@ static const struct ethtool_ops mse102x_ethtool_ops = {
 
 /* driver bus management functions */
 
-#ifdef CONFIG_PM_SLEEP
-
 static int mse102x_suspend(struct device *dev)
 {
        struct mse102x_net *mse = dev_get_drvdata(dev);
@@ -649,9 +647,8 @@ static int mse102x_resume(struct device *dev)
 
        return 0;
 }
-#endif
 
-static SIMPLE_DEV_PM_OPS(mse102x_pm_ops, mse102x_suspend, mse102x_resume);
+static DEFINE_SIMPLE_DEV_PM_OPS(mse102x_pm_ops, mse102x_suspend, mse102x_resume);
 
 static int mse102x_probe_spi(struct spi_device *spi)
 {
@@ -761,7 +758,7 @@ static struct spi_driver mse102x_driver = {
        .driver = {
                .name = DRV_NAME,
                .of_match_table = mse102x_match_table,
-               .pm = &mse102x_pm_ops,
+               .pm = pm_sleep_ptr(&mse102x_pm_ops),
        },
        .probe = mse102x_probe_spi,
        .remove = mse102x_remove_spi,