drivers/pcmcia/m32r_pcc.c: use common error path
authorSudip Mukherjee <sudipm.mukherjee@gmail.com>
Tue, 13 Dec 2016 00:41:02 +0000 (16:41 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 13 Dec 2016 02:55:06 +0000 (18:55 -0800)
Use a common error path for the failure.

Link: http://lkml.kernel.org/r/1474237304-897-2-git-send-email-sudipm.mukherjee@gmail.com
Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/pcmcia/m32r_pcc.c

index fad4455..56bf388 100644 (file)
@@ -689,10 +689,8 @@ static int __init init_m32r_pcc(void)
                return ret;
 
        ret = platform_device_register(&pcc_device);
-       if (ret){
-               platform_driver_unregister(&pcc_driver);
-               return ret;
-       }
+       if (ret)
+               goto unreg_driv;
 
        printk(KERN_INFO "m32r PCC probe:\n");
 
@@ -706,9 +704,8 @@ static int __init init_m32r_pcc(void)
 
        if (pcc_sockets == 0) {
                printk("socket is not found.\n");
-               platform_device_unregister(&pcc_device);
-               platform_driver_unregister(&pcc_driver);
-               return -ENODEV;
+               ret = -ENODEV;
+               goto unreg_dev;
        }
 
        /* Set up interrupt handler(s) */
@@ -734,6 +731,12 @@ static int __init init_m32r_pcc(void)
        }
 
        return 0;
+
+unreg_dev:
+       platform_device_unregister(&pcc_device);
+unreg_driv:
+       platform_driver_unregister(&pcc_driver);
+       return ret;
 } /* init_m32r_pcc */
 
 static void __exit exit_m32r_pcc(void)