net: bridge: use netdev_lockdep_set_classes()
authorEric Dumazet <edumazet@google.com>
Mon, 12 Feb 2024 14:06:59 +0000 (14:06 +0000)
committerJakub Kicinski <kuba@kernel.org>
Wed, 14 Feb 2024 02:45:06 +0000 (18:45 -0800)
br_set_lockdep_class() is missing many details.
Use generic netdev_lockdep_set_classes() to not worry anymore.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/20240212140700.2795436-3-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/bridge/br_device.c

index 65cee0a..717e975 100644 (file)
@@ -108,13 +108,6 @@ out:
        return NETDEV_TX_OK;
 }
 
-static struct lock_class_key bridge_netdev_addr_lock_key;
-
-static void br_set_lockdep_class(struct net_device *dev)
-{
-       lockdep_set_class(&dev->addr_list_lock, &bridge_netdev_addr_lock_key);
-}
-
 static int br_dev_init(struct net_device *dev)
 {
        struct net_bridge *br = netdev_priv(dev);
@@ -153,7 +146,7 @@ static int br_dev_init(struct net_device *dev)
                br_fdb_hash_fini(br);
        }
 
-       br_set_lockdep_class(dev);
+       netdev_lockdep_set_classes(dev);
        return err;
 }