backlight: qcom-wled: Provide enabled_strings default for WLED 4 and 5
authorMarijn Suijten <marijn.suijten@somainline.org>
Mon, 15 Nov 2021 20:34:57 +0000 (21:34 +0100)
committerLee Jones <lee.jones@linaro.org>
Wed, 22 Dec 2021 11:18:02 +0000 (11:18 +0000)
Only WLED 3 sets a sensible default that allows operating this driver
with just qcom,num-strings in the DT; WLED 4 and 5 require
qcom,enabled-strings to be provided otherwise enabled_strings remains
zero-initialized, resulting in every string-specific register write
(currently only the setup and config functions, brightness follows in a
future patch) to only configure the zero'th string multiple times.

Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20211115203459.1634079-8-marijn.suijten@somainline.org
drivers/video/backlight/qcom-wled.c

index 5c5df5a..f975c1f 100644 (file)
@@ -1079,6 +1079,7 @@ static const struct wled_config wled4_config_defaults = {
        .cabc = false,
        .external_pfet = false,
        .auto_detection_enabled = false,
+       .enabled_strings = {0, 1, 2, 3},
 };
 
 static int wled5_setup(struct wled *wled)
@@ -1192,6 +1193,7 @@ static const struct wled_config wled5_config_defaults = {
        .cabc = false,
        .external_pfet = false,
        .auto_detection_enabled = false,
+       .enabled_strings = {0, 1, 2, 3},
 };
 
 static const u32 wled3_boost_i_limit_values[] = {