drm/amd/display: only trigger BIOS related assert for older ASICs
authorDaniel Sa <Daniel.Sa@amd.com>
Tue, 20 Aug 2024 18:19:26 +0000 (14:19 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 2 Sep 2024 15:34:02 +0000 (11:34 -0400)
[Why]
Some asserts are always hit on startup/Pnp when they should only be used
to indicate when something has gone wrong.

[How]
Ignore result of getting function from bios cmd table for newer asics.

Reviewed-by: Jun Lei <jun.lei@amd.com>
Signed-off-by: Daniel Sa <Daniel.Sa@amd.com>
Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/bios/command_table2.c

index 4254bdf..7d18f37 100644 (file)
@@ -227,7 +227,7 @@ static void init_transmitter_control(struct bios_parser *bp)
        uint8_t frev;
        uint8_t crev = 0;
 
-       if (!BIOS_CMD_TABLE_REVISION(dig1transmittercontrol, frev, crev))
+       if (!BIOS_CMD_TABLE_REVISION(dig1transmittercontrol, frev, crev) && (bp->base.ctx->dc->ctx->dce_version <= DCN_VERSION_2_0))
                BREAK_TO_DEBUGGER();
 
        switch (crev) {