serial: 8250: 8250_omap: Work around errata causing spurious IRQs with DMA
authorVignesh Raghavendra <vigneshr@ti.com>
Thu, 19 Mar 2020 11:03:43 +0000 (16:33 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 24 Mar 2020 11:25:11 +0000 (12:25 +0100)
As per Advisory 27 of AM437x Silicon errata document, Spurious UART
interrupts may occur when DMA mode (FCR.DMA_MODE) is enabled. The
Interrupt Controller flags that a UART interrupt has occurred; however,
the associated IT_PENDING bit remains set to 1, indicating that no
interrupt is pending. Acknowledge the spurious interrupts for every
occurrence as workaround.

Errata is applicable to all TI SoCs with this IP.

Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
Link: https://lore.kernel.org/r/20200319110344.21348-6-vigneshr@ti.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/8250/8250_omap.c

index fb709e0..9293a3e 100644 (file)
@@ -1051,7 +1051,7 @@ static int omap_8250_dma_handle_irq(struct uart_port *port)
        iir = serial_port_in(port, UART_IIR);
        if (iir & UART_IIR_NO_INT) {
                serial8250_rpm_put(up);
-               return 0;
+               return IRQ_HANDLED;
        }
 
        spin_lock_irqsave(&port->lock, flags);