bpf: Correctly annotate implicit fall through in bpf_base_func_proto
authorMathieu Malaterre <malat@debian.org>
Wed, 16 Jan 2019 19:35:41 +0000 (20:35 +0100)
committerDaniel Borkmann <daniel@iogearbox.net>
Thu, 17 Jan 2019 15:53:03 +0000 (16:53 +0100)
There is a plan to build the kernel with -Wimplicit-fallthrough and
this place in the code produced a warnings (W=1).

To preserve as much of the existing comment only change a ‘:’ into a ‘,’.
This is enough change, to match the regular expression expected by GCC.

This commit removes the following warning:

  net/core/filter.c:5310:6: warning: this statement may fall through [-Wimplicit-fallthrough=]

Signed-off-by: Mathieu Malaterre <malat@debian.org>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
net/core/filter.c

index 2b3b436..d9076e6 100644 (file)
@@ -5309,7 +5309,7 @@ bpf_base_func_proto(enum bpf_func_id func_id)
        case BPF_FUNC_trace_printk:
                if (capable(CAP_SYS_ADMIN))
                        return bpf_get_trace_printk_proto();
-               /* else: fall through */
+               /* else, fall through */
        default:
                return NULL;
        }