cxgb4vf: shut down the adapter when t4vf_update_port_info() failed in cxgb4vf_open()
authorZhengchao Shao <shaozhengchao@huawei.com>
Wed, 9 Nov 2022 01:21:00 +0000 (09:21 +0800)
committerJakub Kicinski <kuba@kernel.org>
Thu, 10 Nov 2022 03:30:30 +0000 (19:30 -0800)
When t4vf_update_port_info() failed in cxgb4vf_open(), resources applied
during adapter goes up are not cleared. Fix it. Only be compiled, not be
tested.

Fixes: 18d79f721e0a ("cxgb4vf: Update port information in cxgb4vf_open()")
Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
Link: https://lore.kernel.org/r/20221109012100.99132-1-shaozhengchao@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c

index 54db79f..63b2bd0 100644 (file)
@@ -858,7 +858,7 @@ static int cxgb4vf_open(struct net_device *dev)
         */
        err = t4vf_update_port_info(pi);
        if (err < 0)
-               return err;
+               goto err_unwind;
 
        /*
         * Note that this interface is up and start everything up ...