staging: vme_user: Remove NULL-checks
authorSoumya Negi <soumya.negi97@gmail.com>
Fri, 20 Oct 2023 01:55:22 +0000 (18:55 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 21 Oct 2023 10:02:36 +0000 (12:02 +0200)
Don't check for empty bridge device & resource in vme_alloc_consistent()
& vme_free_consistent() since they can not be NULL. Both the VME bridge
device and the VME resource that are used in these functions are set at
probe time.

Signed-off-by: Soumya Negi <soumya.negi97@gmail.com>
Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://lore.kernel.org/r/049bbedf458e8ac40f3dfff9c9b25dce89f5b642.1697763267.git.soumya.negi97@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vme_user/vme.c

index 5efcdf1..661d1ed 100644 (file)
@@ -80,23 +80,7 @@ static struct vme_bridge *find_bridge(struct vme_resource *resource)
 void *vme_alloc_consistent(struct vme_resource *resource, size_t size,
                           dma_addr_t *dma)
 {
-       struct vme_bridge *bridge;
-
-       if (!resource) {
-               printk(KERN_ERR "No resource\n");
-               return NULL;
-       }
-
-       bridge = find_bridge(resource);
-       if (!bridge) {
-               printk(KERN_ERR "Can't find bridge\n");
-               return NULL;
-       }
-
-       if (!bridge->parent) {
-               printk(KERN_ERR "Dev entry NULL for bridge %s\n", bridge->name);
-               return NULL;
-       }
+       struct vme_bridge *bridge = find_bridge(resource);
 
        if (!bridge->alloc_consistent) {
                dev_err(bridge->parent,
@@ -121,23 +105,7 @@ EXPORT_SYMBOL(vme_alloc_consistent);
 void vme_free_consistent(struct vme_resource *resource, size_t size,
                         void *vaddr, dma_addr_t dma)
 {
-       struct vme_bridge *bridge;
-
-       if (!resource) {
-               printk(KERN_ERR "No resource\n");
-               return;
-       }
-
-       bridge = find_bridge(resource);
-       if (!bridge) {
-               printk(KERN_ERR "Can't find bridge\n");
-               return;
-       }
-
-       if (!bridge->parent) {
-               printk(KERN_ERR "Dev entry NULL for bridge %s\n", bridge->name);
-               return;
-       }
+       struct vme_bridge *bridge = find_bridge(resource);
 
        if (!bridge->free_consistent) {
                dev_err(bridge->parent,