vt: simplify noncolor attributes in build_attr
authorJiri Slaby <jslaby@suse.cz>
Mon, 15 Jun 2020 07:49:00 +0000 (09:49 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 24 Jun 2020 15:08:33 +0000 (17:08 +0200)
All the attributes are bools, so do a simple shift instead of tests and
constants as bool is either 0 or 1.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Link: https://lore.kernel.org/r/20200615074910.19267-28-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/vt/vt.c

index 3aff2e3..673177d 100644 (file)
@@ -719,10 +719,10 @@ static u8 build_attr(struct vc_data *vc, u8 _color,
        u8 a = _color;
        if (!vc->vc_can_do_color)
                return _intensity |
-                      (_italic ? 2 : 0) |
-                      (_underline ? 4 : 0) |
-                      (_reverse ? 8 : 0) |
-                      (_blink ? 0x80 : 0);
+                      (_italic    << 1) |
+                      (_underline << 2) |
+                      (_reverse   << 3) |
+                      (_blink     << 7);
        if (_italic)
                a = (a & 0xF0) | vc->vc_itcolor;
        else if (_underline)