projects
/
linux-2.6-microblaze.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
dbc97f8
)
Revert "staging: r8712u: Tracking kmemleak false positives."
author
Nam Cao
<namcaov@gmail.com>
Tue, 25 Oct 2022 09:12:23 +0000
(11:12 +0200)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Mon, 31 Oct 2022 08:08:30 +0000
(09:08 +0100)
This reverts commit
5d3da4a20a271e3cf5496a50cbb8118aa019374f
.
This commit annotated false positive for kmemleak. The reasoning is that
the buffers are freed when the driver is unloaded. However, there is
actually potential memory leak when probe fails.
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Signed-off-by: Nam Cao <namcaov@gmail.com>
Link:
https://lore.kernel.org/r/26ce206b2c40c7db48c146aa6105789db9dfcc1a.1666688642.git.namcaov@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8712/rtl871x_recv.c
patch
|
blob
|
history
diff --git
a/drivers/staging/rtl8712/rtl871x_recv.c
b/drivers/staging/rtl8712/rtl871x_recv.c
index
de9a568
..
4db7eed
100644
(file)
--- a/
drivers/staging/rtl8712/rtl871x_recv.c
+++ b/
drivers/staging/rtl8712/rtl871x_recv.c
@@
-17,9
+17,7
@@
#define _RTL871X_RECV_C_
#include <linux/ip.h>
-#include <linux/slab.h>
#include <linux/if_ether.h>
-#include <linux/kmemleak.h>
#include <linux/etherdevice.h>
#include <linux/ieee80211.h>
#include <net/cfg80211.h>
@@
-61,7
+59,6
@@
void _r8712_init_recv_priv(struct recv_priv *precvpriv,
GFP_ATOMIC);
if (!precvpriv->pallocated_frame_buf)
return;
- kmemleak_not_leak(precvpriv->pallocated_frame_buf);
precvpriv->precv_frame_buf = precvpriv->pallocated_frame_buf +
RXFRAME_ALIGN_SZ -
((addr_t)(precvpriv->pallocated_frame_buf) &