drm/i915: Distinction of memory regions
authorZbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Wed, 3 Feb 2021 17:12:29 +0000 (17:12 +0000)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 24 Mar 2021 18:31:58 +0000 (19:31 +0100)
In preparation for Xe HP multi-tile architecture with multiple memory
regions, we need to be able differentiate multiple instances of device
local-memory.

Note that the region name is just to give it a human friendly
identifier, instead of using class/instance which also uniquely
identifies the region. So far the region name is only for our own
internal debugging in the kernel(like in the selftests), or debugfs
which prints the list of regions, including the regions name.

v2: add commentary for our current region name use

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20210203171231.551338-1-matthew.auld@intel.com
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/gt/intel_gt.c
drivers/gpu/drm/i915/gt/intel_region_lmem.c

index 35ff68a..ca76f93 100644 (file)
@@ -68,6 +68,8 @@ int intel_gt_probe_lmem(struct intel_gt *gt)
        mem->type = INTEL_MEMORY_LOCAL;
        mem->instance = 0;
 
+       intel_memory_region_set_name(mem, "local%u", mem->instance);
+
        GEM_BUG_ON(!HAS_REGION(i915, id));
        GEM_BUG_ON(i915->mm.regions[id]);
        i915->mm.regions[id] = mem;
index 8c498e9..be6f2c8 100644 (file)
@@ -90,8 +90,6 @@ region_lmem_init(struct intel_memory_region *mem)
        if (ret)
                io_mapping_fini(&mem->iomap);
 
-       intel_memory_region_set_name(mem, "local");
-
        return ret;
 }