drm/komeda: plane: Remove redundant zpos initialisation
authorMaxime Ripard <maxime@cerno.tech>
Mon, 21 Feb 2022 09:59:05 +0000 (10:59 +0100)
committerMaxime Ripard <maxime@cerno.tech>
Tue, 8 Mar 2022 11:03:42 +0000 (12:03 +0100)
The komeda KMS driver will call drm_plane_create_zpos_property() with an
init value of the plane index.

Since the initial value wasn't carried over in the state, the driver had
to set it again in komeda_plane_reset(). However, the helpers have been
adjusted to set it properly at reset, so this is not needed anymore.

Cc: Brian Starkey <brian.starkey@arm.com>
Cc: "James (Qian) Wang" <james.qian.wang@arm.com>
Cc: Liviu Dudau <liviu.dudau@arm.com>
Cc: Mihail Atanassov <mihail.atanassov@arm.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Acked-by: Liviu Dudau <liviu.dudau@arm.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220221095918.18763-10-maxime@cerno.tech
drivers/gpu/drm/arm/display/komeda/komeda_plane.c

index 1778f6e..383bb20 100644 (file)
@@ -135,7 +135,6 @@ static void komeda_plane_destroy(struct drm_plane *plane)
 static void komeda_plane_reset(struct drm_plane *plane)
 {
        struct komeda_plane_state *state;
-       struct komeda_plane *kplane = to_kplane(plane);
 
        if (plane->state)
                __drm_atomic_helper_plane_destroy_state(plane->state);
@@ -146,7 +145,6 @@ static void komeda_plane_reset(struct drm_plane *plane)
        state = kzalloc(sizeof(*state), GFP_KERNEL);
        if (state) {
                __drm_atomic_helper_plane_reset(plane, &state->base);
-               state->base.zpos = kplane->layer->base.id;
                state->base.color_encoding = DRM_COLOR_YCBCR_BT601;
                state->base.color_range = DRM_COLOR_YCBCR_LIMITED_RANGE;
        }