platform/x86: intel-hid: Use string_choices API instead of ternary operator
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Wed, 21 Aug 2024 12:04:57 +0000 (15:04 +0300)
committerHans de Goede <hdegoede@redhat.com>
Mon, 26 Aug 2024 14:48:21 +0000 (16:48 +0200)
Use modern string_choices API instead of manually determining the
output using ternary operator.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20240821120458.3702655-1-andriy.shevchenko@linux.intel.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/x86/intel/hid.c

index 10cd654..445e7a5 100644 (file)
@@ -13,6 +13,7 @@
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/platform_device.h>
+#include <linux/string_choices.h>
 #include <linux/suspend.h>
 #include "../dual_accel_detect.h"
 
@@ -331,10 +332,8 @@ static int intel_hid_set_enable(struct device *device, bool enable)
        acpi_handle handle = ACPI_HANDLE(device);
 
        /* Enable|disable features - power button is always enabled */
-       if (!intel_hid_execute_method(handle, INTEL_HID_DSM_HDSM_FN,
-                                     enable)) {
-               dev_warn(device, "failed to %sable hotkeys\n",
-                        enable ? "en" : "dis");
+       if (!intel_hid_execute_method(handle, INTEL_HID_DSM_HDSM_FN, enable)) {
+               dev_warn(device, "failed to %s hotkeys\n", str_enable_disable(enable));
                return -EIO;
        }