crypto: spacc - Fix uninitialized variable in spacc_aead_process()
authorDan Carpenter <dan.carpenter@linaro.org>
Thu, 15 Aug 2024 11:20:04 +0000 (14:20 +0300)
committerHerbert Xu <herbert@gondor.apana.org.au>
Sat, 24 Aug 2024 13:38:54 +0000 (21:38 +0800)
Smatch complains that:

    drivers/crypto/dwc-spacc/spacc_aead.c:1031 spacc_aead_process()
    error: uninitialized symbol 'ptaadsize'.

This could happen if, for example, tctx->mode was CRYPTO_MODE_NULL and
req->cryptlen was less than icvremove.

Fixes: 06af76b46c78 ("crypto: spacc - Add SPAcc aead support")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/dwc-spacc/spacc_aead.c

index 3a617da..abf5971 100755 (executable)
@@ -808,7 +808,7 @@ static int spacc_aead_process(struct aead_request *req, u64 seq, int encrypt)
        u32 dstoff;
        int icvremove;
        int ivaadsize;
-       int ptaadsize;
+       int ptaadsize = 0;
        int iv_to_context;
        int spacc_proc_len;
        u32 spacc_icv_offset = 0;
@@ -959,8 +959,6 @@ static int spacc_aead_process(struct aead_request *req, u64 seq, int encrypt)
            tctx->mode == CRYPTO_MODE_NULL) {
                if (req->cryptlen >= icvremove)
                        ptaadsize = req->cryptlen - icvremove;
-       } else {
-               ptaadsize = 0;
        }
 
        /* Calculate and set the below, important parameters