USB: gadget: udc: Remove some dead code
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 10 Oct 2021 11:33:16 +0000 (13:33 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 10 Oct 2021 13:12:34 +0000 (15:12 +0200)
The 'drd_wq' workqueue_struct has never been used.
It is only destroyed, but never created.

It was introduced in commit 1b9f35adb0ff ("usb: gadget: udc: Add Synopsys
UDC Platform driver")

Remove the corresponding dead code and save some space from the 'udc'
structure.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/9a85b2353843b95e2d86acb3103967fd405a8536.1633865503.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/gadget/udc/amd5536udc.h
drivers/usb/gadget/udc/snps_udc_plat.c

index 3296f3f..0554360 100644 (file)
@@ -572,7 +572,6 @@ struct udc {
        struct extcon_specific_cable_nb extcon_nb;
        struct notifier_block           nb;
        struct delayed_work             drd_work;
-       struct workqueue_struct         *drd_wq;
        u32                             conn_type;
 };
 
index 99805d6..8bbb89c 100644 (file)
@@ -243,11 +243,6 @@ static int udc_plat_remove(struct platform_device *pdev)
 
        platform_set_drvdata(pdev, NULL);
 
-       if (dev->drd_wq) {
-               flush_workqueue(dev->drd_wq);
-               destroy_workqueue(dev->drd_wq);
-       }
-
        phy_power_off(dev->udc_phy);
        phy_exit(dev->udc_phy);
        extcon_unregister_notifier(dev->edev, EXTCON_USB, &dev->nb);