scsi: pmcraid: Select device in pmcraid_eh_target_reset_handler()
authorHannes Reinecke <hare@suse.de>
Mon, 2 Oct 2023 15:43:27 +0000 (17:43 +0200)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 13 Oct 2023 18:23:15 +0000 (14:23 -0400)
The reset code requires a device to be selected, but we shouldn't rely on
the command to provide a device for us. So select the first device on the
target when sending down a target reset.

Signed-off-by: Hannes Reinecke <hare@suse.de>
Link: https://lore.kernel.org/r/20231002154328.43718-18-hare@suse.de
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/pmcraid.c

index d7a3312..a831b34 100644 (file)
@@ -3064,9 +3064,21 @@ static int pmcraid_eh_bus_reset_handler(struct scsi_cmnd *scmd)
 
 static int pmcraid_eh_target_reset_handler(struct scsi_cmnd *scmd)
 {
-       scmd_printk(KERN_INFO, scmd,
+       struct Scsi_Host *shost = scmd->device->host;
+       struct scsi_device *scsi_dev = NULL, *tmp;
+
+       shost_for_each_device(tmp, shost) {
+               if ((tmp->channel == scmd->device->channel) &&
+                   (tmp->id == scmd->device->id)) {
+                       scsi_dev = tmp;
+                       break;
+               }
+       }
+       if (!scsi_dev)
+               return FAILED;
+       sdev_printk(KERN_INFO, scsi_dev,
                    "Doing target reset due to an I/O command timeout.\n");
-       return pmcraid_reset_device(scmd->device,
+       return pmcraid_reset_device(scsi_dev,
                                    PMCRAID_INTERNAL_TIMEOUT,
                                    RESET_DEVICE_TARGET);
 }