ath5k: remove conversion to bool in ath5k_ani_calibration()
authorJason Yan <yanaijie@huawei.com>
Sun, 26 Apr 2020 09:40:37 +0000 (17:40 +0800)
committerKalle Valo <kvalo@codeaurora.org>
Tue, 28 Apr 2020 09:11:27 +0000 (12:11 +0300)
The '>' expression itself is bool, no need to convert it to bool again.
This fixes the following coccicheck warning:

drivers/net/wireless/ath/ath5k/ani.c:504:56-61: WARNING: conversion to
bool not needed here

Signed-off-by: Jason Yan <yanaijie@huawei.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200426094037.23048-1-yanaijie@huawei.com
drivers/net/wireless/ath/ath5k/ani.c

index 0624333..850c608 100644 (file)
@@ -501,7 +501,7 @@ ath5k_ani_calibration(struct ath5k_hw *ah)
 
        if (as->ofdm_errors > ofdm_high || as->cck_errors > cck_high) {
                /* too many PHY errors - we have to raise immunity */
-               bool ofdm_flag = as->ofdm_errors > ofdm_high ? true : false;
+               bool ofdm_flag = as->ofdm_errors > ofdm_high;
                ath5k_ani_raise_immunity(ah, as, ofdm_flag);
                ath5k_ani_period_restart(as);