irqchip/imx-intmux: Use dev_err_probe() to simplify error handling
authorAnson Huang <Anson.Huang@nxp.com>
Tue, 11 Aug 2020 06:16:15 +0000 (14:16 +0800)
committerMarc Zyngier <maz@kernel.org>
Sun, 13 Sep 2020 16:38:52 +0000 (17:38 +0100)
dev_err_probe() can reduce code size, uniform error handling and record the
defer probe reason etc., use it to simplify the code.

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/1597126576-18383-1-git-send-email-Anson.Huang@nxp.com
drivers/irqchip/irq-imx-intmux.c

index e35b7b0..7709f97 100644 (file)
@@ -226,12 +226,9 @@ static int imx_intmux_probe(struct platform_device *pdev)
        }
 
        data->ipg_clk = devm_clk_get(&pdev->dev, "ipg");
-       if (IS_ERR(data->ipg_clk)) {
-               ret = PTR_ERR(data->ipg_clk);
-               if (ret != -EPROBE_DEFER)
-                       dev_err(&pdev->dev, "failed to get ipg clk: %d\n", ret);
-               return ret;
-       }
+       if (IS_ERR(data->ipg_clk))
+               return dev_err_probe(&pdev->dev, PTR_ERR(data->ipg_clk),
+                                    "failed to get ipg clk\n");
 
        data->channum = channum;
        raw_spin_lock_init(&data->lock);