drivers: thermal: tsens: use simpler variables
authorAmit Kucheria <amit.kucheria@linaro.org>
Thu, 12 Mar 2020 12:37:00 +0000 (18:07 +0530)
committerDaniel Lezcano <daniel.lezcano@linaro.org>
Fri, 20 Mar 2020 11:17:48 +0000 (12:17 +0100)
We already dereference the sensor and save it into a variable. Use the
variable directly to make the code easier to read.

Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/5dc4356edfb8dffa377fb561359bf41a6f1fdf17.1584015867.git.amit.kucheria@linaro.org
drivers/thermal/qcom/tsens-common.c

index 45e68f9..f044788 100644 (file)
@@ -369,7 +369,7 @@ irqreturn_t tsens_irq_thread(int irq, void *data)
                        tsens_set_interrupt(priv, hw_id, UPPER, disable);
                        if (d.up_thresh > temp) {
                                dev_dbg(priv->dev, "[%u] %s: re-arm upper\n",
-                                       priv->sensor[i].hw_id, __func__);
+                                       hw_id, __func__);
                                tsens_set_interrupt(priv, hw_id, UPPER, enable);
                        } else {
                                trigger = true;
@@ -380,7 +380,7 @@ irqreturn_t tsens_irq_thread(int irq, void *data)
                        tsens_set_interrupt(priv, hw_id, LOWER, disable);
                        if (d.low_thresh < temp) {
                                dev_dbg(priv->dev, "[%u] %s: re-arm low\n",
-                                       priv->sensor[i].hw_id, __func__);
+                                       hw_id, __func__);
                                tsens_set_interrupt(priv, hw_id, LOWER, enable);
                        } else {
                                trigger = true;
@@ -393,7 +393,7 @@ irqreturn_t tsens_irq_thread(int irq, void *data)
                if (trigger) {
                        dev_dbg(priv->dev, "[%u] %s: TZ update trigger (%d mC)\n",
                                hw_id, __func__, temp);
-                       thermal_zone_device_update(priv->sensor[i].tzd,
+                       thermal_zone_device_update(s->tzd,
                                                   THERMAL_EVENT_UNSPECIFIED);
                } else {
                        dev_dbg(priv->dev, "[%u] %s: no violation:  %d\n",
@@ -436,7 +436,7 @@ int tsens_set_trips(void *_sensor, int low, int high)
        spin_unlock_irqrestore(&priv->ul_lock, flags);
 
        dev_dbg(dev, "[%u] %s: (%d:%d)->(%d:%d)\n",
-               s->hw_id, __func__, d.low_thresh, d.up_thresh, cl_low, cl_high);
+               hw_id, __func__, d.low_thresh, d.up_thresh, cl_low, cl_high);
 
        return 0;
 }