TTY: ircomm, use GFP_KERNEL in ircomm_open()
authorMathias Krause <minipli@googlemail.com>
Fri, 5 Apr 2013 11:02:07 +0000 (11:02 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 8 Apr 2013 16:09:18 +0000 (12:09 -0400)
Hi Greg,

I'm unsure if you or Dave should take that one as it's for one a TTY
patch but also living under net/. So I'm uncertain and let you decide!

Thanks,
Mathias

-- >8 --
Subject: [PATCH] TTY: ircomm, use GFP_KERNEL in ircomm_open()

We're clearly running in non-atomic context as our only call site is
able to call wait_event_interruptible(). So we're safe to use GFP_KERNEL
here instead of GFP_ATOMIC.

Signed-off-by: Mathias Krause <minipli@googlemail.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/irda/ircomm/ircomm_core.c

index 52079f1..b797daa 100644 (file)
@@ -117,7 +117,7 @@ struct ircomm_cb *ircomm_open(notify_t *notify, __u8 service_type, int line)
 
        IRDA_ASSERT(ircomm != NULL, return NULL;);
 
-       self = kzalloc(sizeof(struct ircomm_cb), GFP_ATOMIC);
+       self = kzalloc(sizeof(struct ircomm_cb), GFP_KERNEL);
        if (self == NULL)
                return NULL;