dmaengine: mmp_tdma: share the IRQ line
authorLubomir Rintel <lkundrak@v3.sk>
Mon, 1 Jun 2020 19:22:52 +0000 (21:22 +0200)
committerVinod Koul <vkoul@kernel.org>
Tue, 16 Jun 2020 16:29:01 +0000 (21:59 +0530)
On a MMP2, the DMA interrupt is shared by all channels of the peripheral
DMA controller and the audio DMA controller. Both drivers can identify
their interrupts, but only the PDMA driver marks the line shared:

  [    1.185782] mmp-pdma d4000000.dma: initialized 16 channels
  [    1.186808] mmp-tdma d42a0800.adma: IRQ index 1 not found
  [    1.194317] genirq: Flags mismatch irq 64. 00000000 (tdma) vs. 00000080 (pdma)
  [    1.197894] mmp-tdma: probe of d42a0800.adma failed with error -16

Let's turn on IRQF_SHARED in the ADMA driver as well.

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
Link: https://lore.kernel.org/r/20200601192252.172773-1-lkundrak@v3.sk
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/mmp_tdma.c

index dbc6a48..960c7c4 100644 (file)
@@ -682,7 +682,7 @@ static int mmp_tdma_probe(struct platform_device *pdev)
        if (irq_num != chan_num) {
                irq = platform_get_irq(pdev, 0);
                ret = devm_request_irq(&pdev->dev, irq,
-                       mmp_tdma_int_handler, 0, "tdma", tdev);
+                       mmp_tdma_int_handler, IRQF_SHARED, "tdma", tdev);
                if (ret)
                        return ret;
        }