projects
/
linux-2.6-microblaze.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
51a0d1a
)
drm/bridge: tfp410: fix memleak in get_modes()
author
Tomi Valkeinen
<tomi.valkeinen@ti.com>
Mon, 10 Jun 2019 13:57:38 +0000
(16:57 +0300)
committer
Andrzej Hajda
<a.hajda@samsung.com>
Fri, 14 Jun 2019 07:46:14 +0000
(09:46 +0200)
We don't free the edid blob allocated by the call to drm_get_edid(),
causing a memleak. Fix this by calling kfree(edid) at the end of the
get_modes().
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Link:
https://patchwork.freedesktop.org/patch/msgid/20190610135739.6077-1-tomi.valkeinen@ti.com
drivers/gpu/drm/bridge/ti-tfp410.c
patch
|
blob
|
history
diff --git
a/drivers/gpu/drm/bridge/ti-tfp410.c
b/drivers/gpu/drm/bridge/ti-tfp410.c
index
8b0e71b
..
9f0836c
100644
(file)
--- a/
drivers/gpu/drm/bridge/ti-tfp410.c
+++ b/
drivers/gpu/drm/bridge/ti-tfp410.c
@@
-70,7
+70,12
@@
static int tfp410_get_modes(struct drm_connector *connector)
drm_connector_update_edid_property(connector, edid);
- return drm_add_edid_modes(connector, edid);
+ ret = drm_add_edid_modes(connector, edid);
+
+ kfree(edid);
+
+ return ret;
+
fallback:
/* No EDID, fallback on the XGA standard modes */
ret = drm_add_modes_noedid(connector, 1920, 1200);