libnvdimm, pmem: fix persistence warning
authorDan Williams <dan.j.williams@intel.com>
Tue, 30 May 2017 06:11:57 +0000 (23:11 -0700)
committerDan Williams <dan.j.williams@intel.com>
Tue, 27 Jun 2017 23:44:01 +0000 (16:44 -0700)
The pmem driver assumes if platform firmware describes the memory
devices associated with a persistent memory range and
CONFIG_ARCH_HAS_PMEM_API=y that it has all the mechanism necessary to
flush data to a power-fail safe zone. We warn if the firmware does not
describe memory devices, but we also need to warn if the architecture
does not claim pmem support.

Cc: Jeff Moyer <jmoyer@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Matthew Wilcox <mawilcox@microsoft.com>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
drivers/nvdimm/region_devs.c

index 3c06a6e..41b4cdf 100644 (file)
@@ -1037,8 +1037,9 @@ int nvdimm_has_flush(struct nd_region *nd_region)
 {
        int i;
 
-       /* no nvdimm == flushing capability unknown */
-       if (nd_region->ndr_mappings == 0)
+       /* no nvdimm or pmem api == flushing capability unknown */
+       if (nd_region->ndr_mappings == 0
+                       || !IS_ENABLED(CONFIG_ARCH_HAS_PMEM_API))
                return -ENXIO;
 
        for (i = 0; i < nd_region->ndr_mappings; i++) {