platform/x86: asus-wireless: send an EV_SYN/SYN_REPORT between state changes
authorPeter Hutterer <peter.hutterer@who-t.net>
Mon, 4 Dec 2017 00:26:17 +0000 (10:26 +1000)
committerDarren Hart (VMware) <dvhart@infradead.org>
Tue, 12 Dec 2017 01:26:02 +0000 (17:26 -0800)
Sending the switch state change twice within the same frame is invalid
evdev protocol and only works if the client handles keys immediately as
well. Processing events immediately is incorrect, it forces a fake
order of events that does not exist on the device.

Recent versions of libinput changed to only process the device state and
SYN_REPORT time, so now the key event is lost.

https://bugs.freedesktop.org/show_bug.cgi?id=104041

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org>
drivers/platform/x86/asus-wireless.c

index f379616..d4aeac3 100644 (file)
@@ -118,6 +118,7 @@ static void asus_wireless_notify(struct acpi_device *adev, u32 event)
                return;
        }
        input_report_key(data->idev, KEY_RFKILL, 1);
+       input_sync(data->idev);
        input_report_key(data->idev, KEY_RFKILL, 0);
        input_sync(data->idev);
 }