mm: migrate: remove unused argument vma from migrate_misplaced_folio()
authorDonet Tom <donettom@linux.ibm.com>
Tue, 26 Nov 2024 15:56:54 +0000 (09:56 -0600)
committerAndrew Morton <akpm@linux-foundation.org>
Tue, 14 Jan 2025 06:40:30 +0000 (22:40 -0800)
Commit ee86814b0562 ("mm/migrate: move NUMA hinting fault folio isolation
+ checks under PTL") removed the code that had used the vma argument in
migrate_misplaced_folio.

Since the vma argument was no longer used in migrate_misplaced_folio, this
patch removes it.

Link: https://lkml.kernel.org/r/20241126155655.466186-1-donettom@linux.ibm.com
Signed-off-by: Donet Tom <donettom@linux.ibm.com>
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
Reviewed-by: Zi Yan <ziy@nvidia.com>
Acked-by: David Hildenbrand <david@redhat.com>
Cc: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
include/linux/migrate.h
mm/huge_memory.c
mm/memory.c
mm/migrate.c

index 002e49b..29919fa 100644 (file)
@@ -144,16 +144,14 @@ const struct movable_operations *page_movable_ops(struct page *page)
 #ifdef CONFIG_NUMA_BALANCING
 int migrate_misplaced_folio_prepare(struct folio *folio,
                struct vm_area_struct *vma, int node);
-int migrate_misplaced_folio(struct folio *folio, struct vm_area_struct *vma,
-                          int node);
+int migrate_misplaced_folio(struct folio *folio, int node);
 #else
 static inline int migrate_misplaced_folio_prepare(struct folio *folio,
                struct vm_area_struct *vma, int node)
 {
        return -EAGAIN; /* can't migrate now */
 }
-static inline int migrate_misplaced_folio(struct folio *folio,
-                                        struct vm_area_struct *vma, int node)
+static inline int migrate_misplaced_folio(struct folio *folio, int node)
 {
        return -EAGAIN; /* can't migrate now */
 }
index db64116..45901dc 100644 (file)
@@ -2003,7 +2003,7 @@ vm_fault_t do_huge_pmd_numa_page(struct vm_fault *vmf)
        spin_unlock(vmf->ptl);
        writable = false;
 
-       if (!migrate_misplaced_folio(folio, vma, target_nid)) {
+       if (!migrate_misplaced_folio(folio, target_nid)) {
                flags |= TNF_MIGRATED;
                nid = target_nid;
                task_numa_fault(last_cpupid, nid, HPAGE_PMD_NR, flags);
index 398c031..78b6741 100644 (file)
@@ -5625,7 +5625,7 @@ static vm_fault_t do_numa_page(struct vm_fault *vmf)
        ignore_writable = true;
 
        /* Migrate to the requested node */
-       if (!migrate_misplaced_folio(folio, vma, target_nid)) {
+       if (!migrate_misplaced_folio(folio, target_nid)) {
                nid = target_nid;
                flags |= TNF_MIGRATED;
                task_numa_fault(last_cpupid, nid, nr_pages, flags);
index cc68583..e9e00d1 100644 (file)
@@ -2683,8 +2683,7 @@ int migrate_misplaced_folio_prepare(struct folio *folio,
  * elevated reference count on the folio. This function will un-isolate the
  * folio, dereferencing the folio before returning.
  */
-int migrate_misplaced_folio(struct folio *folio, struct vm_area_struct *vma,
-                           int node)
+int migrate_misplaced_folio(struct folio *folio, int node)
 {
        pg_data_t *pgdat = NODE_DATA(node);
        int nr_remaining;