scsi: qla2xxx: Remove superfluous memset()
authorLi Heng <liheng40@huawei.com>
Thu, 30 Jul 2020 03:31:57 +0000 (11:31 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 21 Aug 2020 03:25:49 +0000 (23:25 -0400)
Fixes coccicheck warning:

./drivers/scsi/qla2xxx/qla_mbx.c:4928:15-33: WARNING: dma_alloc_coherent use in els_cmd_map already zeroes out memory,  so memset is not needed

dma_alloc_coherent() already zeroes out memory so memset() is not needed.

Link: https://lore.kernel.org/r/1596079918-41115-3-git-send-email-liheng40@huawei.com
Signed-off-by: Li Heng <liheng40@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla2xxx/qla_mbx.c

index 7388343..14656da 100644 (file)
@@ -4933,8 +4933,6 @@ qla25xx_set_els_cmds_supported(scsi_qla_host_t *vha)
                return QLA_MEMORY_ALLOC_FAILED;
        }
 
-       memset(els_cmd_map, 0, ELS_CMD_MAP_SIZE);
-
        /* List of Purex ELS */
        cmd_opcode[0] = ELS_FPIN;
        cmd_opcode[1] = ELS_RDP;