assoc_array: fix the return value in assoc_array_insert_mid_shortcut()
authorRoman Smirnov <r.smirnov@omp.ru>
Thu, 7 Mar 2024 07:17:17 +0000 (10:17 +0300)
committerAndrew Morton <akpm@linux-foundation.org>
Tue, 12 Mar 2024 20:09:23 +0000 (13:09 -0700)
Returning the edit variable is redundant because it is dereferenced right
before it is returned.  It would be better to return true.

Found by Linux Verification Center (linuxtesting.org) with Svace.

Link: https://lkml.kernel.org/r/20240307071717.5318-1-r.smirnov@omp.ru
Signed-off-by: Roman Smirnov <r.smirnov@omp.ru>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
lib/assoc_array.c

index ca0b4f3..388e656 100644 (file)
@@ -938,7 +938,7 @@ static bool assoc_array_insert_mid_shortcut(struct assoc_array_edit *edit,
                edit->leaf_p = &new_n0->slots[0];
 
        pr_devel("<--%s() = ok [split shortcut]\n", __func__);
-       return edit;
+       return true;
 }
 
 /**