drbd: Use setup_timer() instead of init_timer() to simplify the code.
authorGeliang Tang <geliangtang@gmail.com>
Tue, 29 Aug 2017 08:20:40 +0000 (10:20 +0200)
committerJens Axboe <axboe@kernel.dk>
Tue, 29 Aug 2017 21:34:45 +0000 (15:34 -0600)
Signed-off-by: Geliang Tang <geliangtang@gmail.com>
Signed-off-by: Roland Kammerer <roland.kammerer@linbit.com>
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/drbd/drbd_main.c

index 11f3852..056d9ab 100644 (file)
@@ -2023,18 +2023,14 @@ void drbd_init_set_defaults(struct drbd_device *device)
        device->unplug_work.cb  = w_send_write_hint;
        device->bm_io_work.w.cb = w_bitmap_io;
 
-       init_timer(&device->resync_timer);
-       init_timer(&device->md_sync_timer);
-       init_timer(&device->start_resync_timer);
-       init_timer(&device->request_timer);
-       device->resync_timer.function = resync_timer_fn;
-       device->resync_timer.data = (unsigned long) device;
-       device->md_sync_timer.function = md_sync_timer_fn;
-       device->md_sync_timer.data = (unsigned long) device;
-       device->start_resync_timer.function = start_resync_timer_fn;
-       device->start_resync_timer.data = (unsigned long) device;
-       device->request_timer.function = request_timer_fn;
-       device->request_timer.data = (unsigned long) device;
+       setup_timer(&device->resync_timer, resync_timer_fn,
+                       (unsigned long)device);
+       setup_timer(&device->md_sync_timer, md_sync_timer_fn,
+                       (unsigned long)device);
+       setup_timer(&device->start_resync_timer, start_resync_timer_fn,
+                       (unsigned long)device);
+       setup_timer(&device->request_timer, request_timer_fn,
+                       (unsigned long)device);
 
        init_waitqueue_head(&device->misc_wait);
        init_waitqueue_head(&device->state_wait);