drm/amd/display: change when to set tap_hardcode_coeff
authorBhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>
Thu, 5 Oct 2017 17:32:29 +0000 (13:32 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Sat, 21 Oct 2017 20:49:12 +0000 (16:49 -0400)
Set hardcode_coeff only when BOTH chroma and luma taps are
more than 1

without this underscan with h or v set to 0 darkens
the screen (either h or v set to 0, not both)

Signed-off-by: Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>
Reviewed-by: Tony Cheng <Tony.Cheng@amd.com>
Acked-by: Harry Wentland <Harry.Wentland@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c

index 830dbd5..eda6c80 100644 (file)
@@ -306,10 +306,10 @@ static void dpp_set_scl_filter(
 
        h_2tap_hardcode_coef_en = scl_data->taps.h_taps < 3
                                        && scl_data->taps.h_taps_c < 3
-               && (scl_data->taps.h_taps > 1 || scl_data->taps.h_taps_c > 1);
+               && (scl_data->taps.h_taps > 1 && scl_data->taps.h_taps_c > 1);
        v_2tap_hardcode_coef_en = scl_data->taps.v_taps < 3
                                        && scl_data->taps.v_taps_c < 3
-               && (scl_data->taps.v_taps > 1 || scl_data->taps.v_taps_c > 1);
+               && (scl_data->taps.v_taps > 1 && scl_data->taps.v_taps_c > 1);
 
        h_2tap_sharp_en = h_2tap_hardcode_coef_en && h_2tap_sharp_factor != 0;
        v_2tap_sharp_en = v_2tap_hardcode_coef_en && v_2tap_sharp_factor != 0;