tcp: remove dead code from tcp_collapse_retrans()
authorEric Dumazet <edumazet@google.com>
Wed, 27 Oct 2021 20:19:19 +0000 (13:19 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 28 Oct 2021 11:44:38 +0000 (12:44 +0100)
TCP sendmsg() no longer puts payload in skb->head,
remove some dead code from tcp_collapse_retrans().

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp_output.c

index c0c55a8..e1dcc93 100644 (file)
@@ -3045,13 +3045,9 @@ static bool tcp_collapse_retrans(struct sock *sk, struct sk_buff *skb)
 
        BUG_ON(tcp_skb_pcount(skb) != 1 || tcp_skb_pcount(next_skb) != 1);
 
-       if (next_skb_size) {
-               if (next_skb_size <= skb_availroom(skb))
-                       skb_copy_bits(next_skb, 0, skb_put(skb, next_skb_size),
-                                     next_skb_size);
-               else if (!tcp_skb_shift(skb, next_skb, 1, next_skb_size))
-                       return false;
-       }
+       if (next_skb_size && !tcp_skb_shift(skb, next_skb, 1, next_skb_size))
+               return false;
+
        tcp_highest_sack_replace(sk, next_skb, skb);
 
        /* Update sequence range on original skb. */