media: mxl5005s: drop some dead code

As reported by clang (with W=1), the ctrlVal var is never used.

Yet, there are even some loops to estimate it. As this is dead
code, remove it. If ever needed, someone could revert this
patch.

Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

diff --git a/drivers/media/tuners/mxl5005s.c b/drivers/media/tuners/mxl5005s.c
index f6e82a8..ab4c43d 100644 (file)
--- a/drivers/media/tuners/mxl5005s.c
+++ b/drivers/media/tuners/mxl5005s.c
@@ -3414,9 +3414,8 @@ static u16 MXL_ControlWrite_Group(struct dvb_frontend *fe, u16 controlNum,
        u32 value, u16 controlGroup)
 {
        struct mxl5005s_state *state = fe->tuner_priv;
-       u16 i, j, k;
+       u16 i, j;
        u32 highLimit;
-       u32 ctrlVal;
 
        if (controlGroup == 1) /* Initial Control */ {
 
@@ -3432,9 +3431,6 @@ static u16 MXL_ControlWrite_Group(struct dvb_frontend *fe, u16 controlNum,
                                                        (u8)(state->Init_Ctrl[i].bit[j]),
                                                        (u8)((value>>j) & 0x01));
                                        }
-                                       ctrlVal = 0;
-                                       for (k = 0; k < state->Init_Ctrl[i].size; k++)
-                                               ctrlVal += state->Init_Ctrl[i].val[k] * (1 << k);
                                } else
                                        return -1;
                        }
@@ -3454,9 +3450,6 @@ static u16 MXL_ControlWrite_Group(struct dvb_frontend *fe, u16 controlNum,
                                                        (u8)(state->CH_Ctrl[i].bit[j]),
                                                        (u8)((value>>j) & 0x01));
                                        }
-                                       ctrlVal = 0;
-                                       for (k = 0; k < state->CH_Ctrl[i].size; k++)
-                                               ctrlVal += state->CH_Ctrl[i].val[k] * (1 << k);
                                } else
                                        return -1;
                        }
@@ -3477,11 +3470,6 @@ static u16 MXL_ControlWrite_Group(struct dvb_frontend *fe, u16 controlNum,
                                                        (u8)(state->MXL_Ctrl[i].bit[j]),
                                                        (u8)((value>>j) & 0x01));
                                        }
-                                       ctrlVal = 0;
-                                       for (k = 0; k < state->MXL_Ctrl[i].size; k++)
-                                               ctrlVal += state->
-                                                       MXL_Ctrl[i].val[k] *
-                                                       (1 << k);
                                } else
                                        return -1;
                        }