drm: bridge: it66121: Check drm_bridge_attach retval
authorRobert Foss <robert.foss@linaro.org>
Thu, 5 Aug 2021 18:50:39 +0000 (20:50 +0200)
committerRobert Foss <robert.foss@linaro.org>
Fri, 6 Aug 2021 08:48:25 +0000 (10:48 +0200)
The return value of drm_bridge_attach() is ignored during
the it66121_bridge_attach() call, which is incorrect.

Fixes: 988156dc2fc9 ("drm: bridge: add it66121 driver")
Signed-off-by: Robert Foss <robert.foss@linaro.org>
Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210805185039.402178-1-robert.foss@linaro.org
Link: https://patchwork.freedesktop.org/patch/msgid/20210805185039.402178-1-robert.foss@linaro.org
drivers/gpu/drm/bridge/ite-it66121.c

index 7149ed4..2f2a09a 100644 (file)
@@ -536,6 +536,8 @@ static int it66121_bridge_attach(struct drm_bridge *bridge,
                return -EINVAL;
 
        ret = drm_bridge_attach(bridge->encoder, ctx->next_bridge, bridge, flags);
+       if (ret)
+               return ret;
 
        ret = regmap_write_bits(ctx->regmap, IT66121_CLK_BANK_REG,
                                IT66121_CLK_BANK_PWROFF_RCLK, 0);