drm: Remove legacy cursor hotspot code

Atomic modesetting supports mouse cursor offsets via the hotspot
properties that are created on cursor planes. All drivers which
support hotspots are atomic and the legacy code has been implemented
in terms of the atomic properties as well.

Due to the above the lagacy cursor hotspot code is no longer used or
needed and can be removed.

Signed-off-by: Zack Rusin <zackr@vmware.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231023074613.41327-8-aesteve@redhat.com

diff --git a/drivers/gpu/drm/drm_plane.c b/drivers/gpu/drm/drm_plane.c
index eaca367..1dc00ad 100644 (file)
--- a/drivers/gpu/drm/drm_plane.c
+++ b/drivers/gpu/drm/drm_plane.c
@@ -1110,9 +1110,6 @@ static int drm_mode_cursor_universal(struct drm_crtc *crtc,
                                return PTR_ERR(fb);
                        }
 
-                       fb->hot_x = req->hot_x;
-                       fb->hot_y = req->hot_y;
-
                        if (plane->hotspot_x_property && plane->state)
                                plane->state->hotspot_x = req->hot_x;
                        if (plane->hotspot_y_property && plane->state)

diff --git a/include/drm/drm_framebuffer.h b/include/drm/drm_framebuffer.h
index 80ece7b..6680770 100644 (file)
--- a/include/drm/drm_framebuffer.h
+++ b/include/drm/drm_framebuffer.h
@@ -188,18 +188,6 @@ struct drm_framebuffer {
         * DRM_MODE_FB_MODIFIERS.
         */
        int flags;
-       /**
-        * @hot_x: X coordinate of the cursor hotspot. Used by the legacy cursor
-        * IOCTL when the driver supports cursor through a DRM_PLANE_TYPE_CURSOR
-        * universal plane.
-        */
-       int hot_x;
-       /**
-        * @hot_y: Y coordinate of the cursor hotspot. Used by the legacy cursor
-        * IOCTL when the driver supports cursor through a DRM_PLANE_TYPE_CURSOR
-        * universal plane.
-        */
-       int hot_y;
        /**
         * @filp_head: Placed on &drm_file.fbs, protected by &drm_file.fbs_lock.
         */