Input: sunkbd - use guard notation when pausing serio port
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Thu, 5 Sep 2024 04:17:12 +0000 (21:17 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Fri, 4 Oct 2024 07:58:15 +0000 (00:58 -0700)
Using guard notation makes the code more compact and error handling
more robust by ensuring that serio ports are resumed in all code paths
when control leaves critical section.

Link: https://lore.kernel.org/r/20240905041732.2034348-8-dmitry.torokhov@gmail.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/keyboard/sunkbd.c

index 72fb460..3299e19 100644 (file)
@@ -241,9 +241,8 @@ static void sunkbd_reinit(struct work_struct *work)
 
 static void sunkbd_enable(struct sunkbd *sunkbd, bool enable)
 {
-       serio_pause_rx(sunkbd->serio);
-       sunkbd->enabled = enable;
-       serio_continue_rx(sunkbd->serio);
+       scoped_guard(serio_pause_rx, sunkbd->serio)
+               sunkbd->enabled = enable;
 
        if (!enable) {
                wake_up_interruptible(&sunkbd->wait);