fs: dlm: Remove some useless memset()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Tue, 10 Oct 2023 22:04:43 +0000 (18:04 -0400)
committerDavid Teigland <teigland@redhat.com>
Thu, 12 Oct 2023 20:20:17 +0000 (15:20 -0500)
There is no need to clear the buffer used to build the file name.

snprintf() already guarantees that it is NULL terminated and such a
(useless) precaution was not done for the first string (i.e
ls_debug_rsb_dentry)

So, save a few LoC.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Alexander Aring <aahringo@redhat.com>
Signed-off-by: David Teigland <teigland@redhat.com>
fs/dlm/debug_fs.c

index c93359c..42f332f 100644 (file)
@@ -986,7 +986,6 @@ void dlm_create_debug_file(struct dlm_ls *ls)
 
        /* format 2 */
 
-       memset(name, 0, sizeof(name));
        snprintf(name, sizeof(name), "%s_locks", ls->ls_name);
 
        ls->ls_debug_locks_dentry = debugfs_create_file(name,
@@ -997,7 +996,6 @@ void dlm_create_debug_file(struct dlm_ls *ls)
 
        /* format 3 */
 
-       memset(name, 0, sizeof(name));
        snprintf(name, sizeof(name), "%s_all", ls->ls_name);
 
        ls->ls_debug_all_dentry = debugfs_create_file(name,
@@ -1008,7 +1006,6 @@ void dlm_create_debug_file(struct dlm_ls *ls)
 
        /* format 4 */
 
-       memset(name, 0, sizeof(name));
        snprintf(name, sizeof(name), "%s_toss", ls->ls_name);
 
        ls->ls_debug_toss_dentry = debugfs_create_file(name,
@@ -1017,7 +1014,6 @@ void dlm_create_debug_file(struct dlm_ls *ls)
                                                       ls,
                                                       &format4_fops);
 
-       memset(name, 0, sizeof(name));
        snprintf(name, sizeof(name), "%s_waiters", ls->ls_name);
 
        ls->ls_debug_waiters_dentry = debugfs_create_file(name,
@@ -1028,7 +1024,6 @@ void dlm_create_debug_file(struct dlm_ls *ls)
 
        /* format 5 */
 
-       memset(name, 0, sizeof(name));
        snprintf(name, sizeof(name), "%s_queued_asts", ls->ls_name);
 
        ls->ls_debug_queued_asts_dentry = debugfs_create_file(name,